[lgtm] Fix LGTM build on 202012 branch #1921

kcudnik · 2021-09-21T08:52:53Z

What I did

Why I did it

How I verified it

Details if related

nazariig · 2021-09-21T12:46:48Z

@kcudnik FYI. #1868

nazariig · 2021-09-21T12:57:01Z

lgtm.yml

    after_prepare:
-      - git clone https://github.com/Azure/sonic-swss-common; pushd sonic-swss-common; ./autogen.sh; fakeroot dpkg-buildpackage -us -uc -b; popd
+      - git clone https://github.com/Azure/sonic-swss-common; pushd sonic-swss-common; git checkout origin/202012; ./autogen.sh; fakeroot dpkg-buildpackage -us -uc -b; popd


@kcudnik suggest to have git clone -b 202012 https://github.com/Azure/sonic-swss-common

nazariig · 2021-09-21T12:58:00Z

lgtm.yml

-      - dpkg-deb -x libsaimetadata-dev_1.0.0_amd64.deb $LGTM_WORKSPACE
-      - dpkg-deb -x libsaivs_1.0.0_amd64.deb $LGTM_WORKSPACE
-      - dpkg-deb -x libsaivs-dev_1.0.0_amd64.deb $LGTM_WORKSPACE
+      - git clone --recursive https://github.com/Azure/sonic-sairedis; pushd sonic-sairedis; git checkout origin/202012; ./autogen.sh; DEB_BUILD_OPTIONS=nocheck SWSS_COMMON_INC="$LGTM_WORKSPACE/usr/include" SWSS_COMMON_LIB="$LGTM_WORKSPACE/usr/lib/x86_64-linux-gnu" fakeroot debian/rules binary-syncd-vs; popd


@kcudnik suggest to have git clone -b 202012 --recursive https://github.com/Azure/sonic-sairedis

nazariig · 2021-09-21T13:00:30Z

lgtm.yml

+      - dpkg-deb -vx libsaimetadata_1.0.0_amd64.deb $LGTM_WORKSPACE
+      - dpkg-deb -vx libsaimetadata-dev_1.0.0_amd64.deb $LGTM_WORKSPACE
+      - dpkg-deb -vx libsaivs_1.0.0_amd64.deb $LGTM_WORKSPACE
+      - dpkg-deb -vx libsaivs-dev_1.0.0_amd64.deb $LGTM_WORKSPACE


@kcudnik do we need to have dpkg-deb -vx in master?

i added this for debugging, currently we dont need that

@kcudnik got it

nazariig · 2021-09-21T15:00:58Z

@kcudnik FYI. The fix is good.

The analysis for the base commit (5a4678e) was not successful. For more information, see the build and analysis logs on LGTM.com

C/C++—Failed6 hours ago

Preparing merge commit (e18451c)—Succeeded
Build merge (6d54a69)—Succeeded (lines of code: 67.3k analyzed; 67.6k estimated)
Build 202012 (5a4678e)—Failed with bad exit code during 'Extraction' (lines of code: 67.6k estimated)

merge commit:

[2021-09-21 14:03:19] [build-stdout] Configuration file:
[2021-09-21 14:03:19] [build-stdout] path_classifiers:
[2021-09-21 14:03:19] [build-stdout]   test:
[2021-09-21 14:03:19] [build-stdout]     exclude: tests
[2021-09-21 14:03:19] [build-stdout] extraction:
[2021-09-21 14:03:19] [build-stdout]   python:
[2021-09-21 14:03:19] [build-stdout]     python_setup:
[2021-09-21 14:03:19] [build-stdout]       version: "2"
[2021-09-21 14:03:19] [build-stdout]   cpp:
[2021-09-21 14:03:19] [build-stdout]     prepare:
[2021-09-21 14:03:19] [build-stdout]       packages:
[2021-09-21 14:03:19] [build-stdout]       - libxml-simple-perl
[2021-09-21 14:03:19] [build-stdout]       - aspell
[2021-09-21 14:03:19] [build-stdout]       - aspell-en
[2021-09-21 14:03:19] [build-stdout]       - libhiredis-dev
[2021-09-21 14:03:19] [build-stdout]       - libnl-3-dev
[2021-09-21 14:03:19] [build-stdout]       - libnl-genl-3-dev
[2021-09-21 14:03:19] [build-stdout]       - libnl-route-3-dev
[2021-09-21 14:03:19] [build-stdout]       - libnl-nf-3-dev
[2021-09-21 14:03:19] [build-stdout]       - libzmq3-dev
[2021-09-21 14:03:19] [build-stdout]       - libzmq5
[2021-09-21 14:03:19] [build-stdout]       - swig3.0
[2021-09-21 14:03:19] [build-stdout]       - libpython2.7-dev
[2021-09-21 14:03:19] [build-stdout]       - libgtest-dev
[2021-09-21 14:03:19] [build-stdout]       - dh-exec
[2021-09-21 14:03:19] [build-stdout]       - doxygen
[2021-09-21 14:03:19] [build-stdout]       - graphviz
[2021-09-21 14:03:19] [build-stdout]       - autoconf-archive
[2021-09-21 14:03:19] [build-stdout]     after_prepare:
[2021-09-21 14:03:19] [build-stdout]       - git clone -b 202012 https://github.com/Azure/sonic-swss-common; pushd sonic-swss-common; ./autogen.sh; fakeroot dpkg-buildpackage -us -uc -b; popd
[2021-09-21 14:03:19] [build-stdout]       - dpkg-deb -x libswsscommon_1.0.0_amd64.deb $LGTM_WORKSPACE
[2021-09-21 14:03:19] [build-stdout]       - dpkg-deb -x libswsscommon-dev_1.0.0_amd64.deb $LGTM_WORKSPACE
[2021-09-21 14:03:19] [build-stdout]       - git clone -b 202012 --recursive https://github.com/Azure/sonic-sairedis; pushd sonic-sairedis; ./autogen.sh; DEB_BUILD_OPTIONS=nocheck SWSS_COMMON_INC="$LGTM_WORKSPACE/usr/include" SWSS_COMMON_LIB="$LGTM_WORKSPACE/usr/lib/x86_64-linux-gnu" fakeroot debian/rules binary-syncd-vs; popd
[2021-09-21 14:03:19] [build-stdout]       - dpkg-deb -vx libsairedis_1.0.0_amd64.deb $LGTM_WORKSPACE
[2021-09-21 14:03:19] [build-stdout]       - dpkg-deb -vx libsairedis-dev_1.0.0_amd64.deb $LGTM_WORKSPACE
[2021-09-21 14:03:19] [build-stdout]       - dpkg-deb -vx libsaimetadata_1.0.0_amd64.deb $LGTM_WORKSPACE
[2021-09-21 14:03:19] [build-stdout]       - dpkg-deb -vx libsaimetadata-dev_1.0.0_amd64.deb $LGTM_WORKSPACE
[2021-09-21 14:03:19] [build-stdout]       - dpkg-deb -vx libsaivs_1.0.0_amd64.deb $LGTM_WORKSPACE
[2021-09-21 14:03:19] [build-stdout]       - dpkg-deb -vx libsaivs-dev_1.0.0_amd64.deb $LGTM_WORKSPACE
[2021-09-21 14:03:19] [build-stdout]     configure:
[2021-09-21 14:03:19] [build-stdout]       command:
[2021-09-21 14:03:19] [build-stdout]       - ./autogen.sh
[2021-09-21 14:03:19] [build-stdout]       - ls -al $LGTM_WORKSPACE/usr/include/sai || true ; ls -al /usr/include/sai || true
[2021-09-21 14:03:19] [build-stdout]       - find / -name sai.h -ls || true
[2021-09-21 14:03:19] [build-stdout]       - ./configure --prefix=/usr --with-extra-inc=$LGTM_WORKSPACE/usr/include --with-extra-lib=$LGTM_WORKSPACE/usr/lib/x86_64-linux-gnu
Running command in /opt/src: [/opt/work/lgtm-workspace/lgtm/extract.sh]

base commit:

[2021-09-21 08:53:34] [build-stdout] Configuration file:
[2021-09-21 08:53:34] [build-stdout] path_classifiers:
[2021-09-21 08:53:34] [build-stdout]   test:
[2021-09-21 08:53:34] [build-stdout]     exclude: tests
[2021-09-21 08:53:34] [build-stdout] extraction:
[2021-09-21 08:53:34] [build-stdout]   python:
[2021-09-21 08:53:34] [build-stdout]     python_setup:
[2021-09-21 08:53:34] [build-stdout]       version: "2"
[2021-09-21 08:53:34] [build-stdout]   cpp:
[2021-09-21 08:53:34] [build-stdout]     prepare:
[2021-09-21 08:53:34] [build-stdout]       packages:
[2021-09-21 08:53:34] [build-stdout]       - libxml-simple-perl
[2021-09-21 08:53:34] [build-stdout]       - aspell
[2021-09-21 08:53:34] [build-stdout]       - aspell-en
[2021-09-21 08:53:34] [build-stdout]       - libhiredis-dev
[2021-09-21 08:53:34] [build-stdout]       - libnl-3-dev
[2021-09-21 08:53:34] [build-stdout]       - libnl-genl-3-dev
[2021-09-21 08:53:34] [build-stdout]       - libnl-route-3-dev
[2021-09-21 08:53:34] [build-stdout]       - libnl-nf-3-dev
[2021-09-21 08:53:34] [build-stdout]       - libzmq3-dev
[2021-09-21 08:53:34] [build-stdout]       - libzmq5
[2021-09-21 08:53:34] [build-stdout]       - swig3.0
[2021-09-21 08:53:34] [build-stdout]       - libpython2.7-dev
[2021-09-21 08:53:34] [build-stdout]       - libgtest-dev
[2021-09-21 08:53:34] [build-stdout]       - dh-exec
[2021-09-21 08:53:34] [build-stdout]       - doxygen
[2021-09-21 08:53:34] [build-stdout]       - graphviz
[2021-09-21 08:53:34] [build-stdout]     after_prepare:
[2021-09-21 08:53:34] [build-stdout]       - git clone https://github.com/Azure/sonic-swss-common; pushd sonic-swss-common; ./autogen.sh; fakeroot dpkg-buildpackage -us -uc -b; popd
[2021-09-21 08:53:34] [build-stdout]       - dpkg-deb -x libswsscommon_1.0.0_amd64.deb $LGTM_WORKSPACE
[2021-09-21 08:53:34] [build-stdout]       - dpkg-deb -x libswsscommon-dev_1.0.0_amd64.deb $LGTM_WORKSPACE
[2021-09-21 08:53:34] [build-stdout]       - git clone --recursive https://github.com/Azure/sonic-sairedis; pushd sonic-sairedis; ./autogen.sh; DEB_BUILD_OPTIONS=nocheck SWSS_COMMON_INC="$LGTM_WORKSPACE/usr/include" SWSS_COMMON_LIB="$LGTM_WORKSPACE/usr/lib/x86_64-linux-gnu" fakeroot debian/rules binary-syncd-vs; popd
[2021-09-21 08:53:34] [build-stdout]       - dpkg-deb -x libsairedis_1.0.0_amd64.deb $LGTM_WORKSPACE
[2021-09-21 08:53:34] [build-stdout]       - dpkg-deb -x libsairedis-dev_1.0.0_amd64.deb $LGTM_WORKSPACE
[2021-09-21 08:53:34] [build-stdout]       - dpkg-deb -x libsaimetadata_1.0.0_amd64.deb $LGTM_WORKSPACE
[2021-09-21 08:53:34] [build-stdout]       - dpkg-deb -x libsaimetadata-dev_1.0.0_amd64.deb $LGTM_WORKSPACE
[2021-09-21 08:53:34] [build-stdout]       - dpkg-deb -x libsaivs_1.0.0_amd64.deb $LGTM_WORKSPACE
[2021-09-21 08:53:34] [build-stdout]       - dpkg-deb -x libsaivs-dev_1.0.0_amd64.deb $LGTM_WORKSPACE
[2021-09-21 08:53:34] [build-stdout]     configure:
[2021-09-21 08:53:34] [build-stdout]       command:
[2021-09-21 08:53:34] [build-stdout]       - ./autogen.sh
[2021-09-21 08:53:34] [build-stdout]       - ./configure --prefix=/usr --with-extra-inc=$LGTM_WORKSPACE/usr/include --with-extra-lib=$LGTM_WORKSPACE/usr/lib/x86_64-linux-gnu
Running command in /opt/src: [/opt/work/lgtm-workspace/lgtm/extract.sh]

Need to add it to 202012 ASAP

nazariig · 2021-09-21T16:17:53Z

lgtm.yml

-      - dpkg-deb -x libsaivs_1.0.0_amd64.deb $LGTM_WORKSPACE
-      - dpkg-deb -x libsaivs-dev_1.0.0_amd64.deb $LGTM_WORKSPACE
+      - git clone -b 202012 --recursive https://github.com/Azure/sonic-sairedis; pushd sonic-sairedis; ./autogen.sh; DEB_BUILD_OPTIONS=nocheck SWSS_COMMON_INC="$LGTM_WORKSPACE/usr/include" SWSS_COMMON_LIB="$LGTM_WORKSPACE/usr/lib/x86_64-linux-gnu" fakeroot debian/rules binary-syncd-vs; popd
+      - dpkg-deb -vx libsairedis_1.0.0_amd64.deb $LGTM_WORKSPACE


@kcudnik do we need to remove this debug stuff: dpkg-deb -vx?

nazariig · 2021-09-21T16:18:05Z

lgtm.yml

    configure:
      command:
      - ./autogen.sh
+      - ls -al $LGTM_WORKSPACE/usr/include/sai || true ; ls -al /usr/include/sai || true
+      - find / -name sai.h -ls || true


@kcudnik do we need to remove this debug stuff?

nazariig · 2021-09-21T16:18:13Z

orchagent/main.cpp

@@ -33,6 +33,8 @@ extern "C" {
 using namespace std;
 using namespace swss;

+
+


@kcudnik do we need to remove this debug stuff?

kcudnik · 2021-09-21T17:53:59Z

not sure why latests builds dont pull lgtm.yml changes

nazariig · 2021-09-21T19:33:33Z

@lguohan can you please help to merge?

qiluo-msft · 2021-09-22T01:13:04Z

Is it true that the failing LGTM log indicates it is not using 202012 branch? There is no git clone -b 202012 as in your PR.

kcudnik · 2021-09-22T04:28:10Z

Is it true that the failing LGTM log indicates it is not using 202012 branch? There is no git clone -b 202012 as in your PR.

there is no specific clone for sonic-swss in lgtm.yml

kcudnik · 2021-09-24T10:21:03Z

ping, c++ should start passing after it will this commit will be merged

… field in Bearer fields (sonic-net#1921) Signed-off-by: Stepan Blyschak [email protected] What I did If Auth service did not reply with "service" field, don't fail and request the token without it. How I did it Modified registry.py and added UT. How to verify it Tested on DUT.

kcudnik added 2 commits September 21, 2021 10:50

[202012] Test LGTM sai headers issue

776be07

add find

3b49f93

kcudnik mentioned this pull request Sep 21, 2021

[202012][teammgrd]: Improve LAGs cleanup on shutdown #1916

Merged

kcudnik added 2 commits September 21, 2021 11:14

update find

40dfaf9

add verbose on dpkg

2649e0a

kcudnik added 2 commits September 21, 2021 14:48

add autoconf-archive

b5d5c82

Compile sairedis and swss-common for 202012 branch

c4e4689

nazariig reviewed Sep 21, 2021

View reviewed changes

kcudnik added 3 commits September 21, 2021 15:02

checkout branch directly on lgtm

95601bb

reorder branch on clone

210883f

Dummy

e18451c

Add lzmq to cfgmgr

c370cdb

kcudnik changed the title ~~Lgtmtest~~ [lgtm] Fix LGTM build on 202012 branch Sep 21, 2021

nazariig requested review from lguohan, qiluo-msft, prsunny, liat-grozovik and volodymyrsamotiy September 21, 2021 15:54

nazariig added the Bug 🐛 label Sep 21, 2021

nazariig reviewed Sep 21, 2021

View reviewed changes

Remove debug stuff

15b389d

nazariig approved these changes Sep 21, 2021

View reviewed changes

prsunny approved these changes Sep 23, 2021

View reviewed changes

kcudnik merged commit 84f1c63 into sonic-net:202012 Sep 24, 2021

kcudnik deleted the lgtmtest branch September 24, 2021 12:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[lgtm] Fix LGTM build on 202012 branch #1921

[lgtm] Fix LGTM build on 202012 branch #1921

kcudnik commented Sep 21, 2021

nazariig commented Sep 21, 2021

nazariig Sep 21, 2021 •

edited

Loading

kcudnik Sep 21, 2021

nazariig Sep 21, 2021 •

edited

Loading

kcudnik Sep 21, 2021

nazariig Sep 21, 2021

kcudnik Sep 21, 2021 •

edited

Loading

nazariig Sep 21, 2021

nazariig commented Sep 21, 2021 •

edited

Loading

nazariig Sep 21, 2021

nazariig Sep 21, 2021

kcudnik Sep 21, 2021

nazariig Sep 21, 2021

kcudnik Sep 21, 2021

kcudnik commented Sep 21, 2021

nazariig commented Sep 21, 2021

qiluo-msft commented Sep 22, 2021

kcudnik commented Sep 22, 2021

kcudnik commented Sep 24, 2021

		@@ -33,6 +33,8 @@ extern "C" {
		using namespace std;
		using namespace swss;

[lgtm] Fix LGTM build on 202012 branch #1921

[lgtm] Fix LGTM build on 202012 branch #1921

Conversation

kcudnik commented Sep 21, 2021

nazariig commented Sep 21, 2021

nazariig Sep 21, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nazariig Sep 21, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kcudnik Sep 21, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nazariig commented Sep 21, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kcudnik commented Sep 21, 2021

nazariig commented Sep 21, 2021

qiluo-msft commented Sep 22, 2021

kcudnik commented Sep 22, 2021

kcudnik commented Sep 24, 2021

nazariig Sep 21, 2021 •

edited

Loading

nazariig Sep 21, 2021 •

edited

Loading

kcudnik Sep 21, 2021 •

edited

Loading

nazariig commented Sep 21, 2021 •

edited

Loading